[PATCH] D125645: [ARM SEH 3] [ARM] [MC] Add support for writing ARM WinEH unwind info

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 16:52:55 PDT 2022


efriedma added inline comments.


================
Comment at: llvm/lib/MC/MCWin64EH.cpp:1431
+    streamer.emitValue(
+        MCBinaryExpr::createOr(FuncLengthExpr,
+                               MCConstantExpr::create(row1, context), context),
----------------
mstorsjo wrote:
> How do I make this into an ARM specific fixup, which could do range checking for `FuncLengthExpr` and error out if the function is too long?
See llvm/lib/Target/ARM/MCTargetDesc/ARMMCExpr.h.

I'd prefer not to put any substantial effort into infrastructure we won't need if we implement splitting, though.  Zhaoshi is currently looking into that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125645/new/

https://reviews.llvm.org/D125645



More information about the llvm-commits mailing list