[llvm] d4545e6 - Revert "[RISCV] Enable strict assertions in InsertVSETVLI data flow"

[Philip Reames via llvm-commits]

Author: Philip Reames
Date: 2022-05-17T15:53:13-07:00
New Revision: d4545e6fa0366718c2416d3578dd4e1f26855c29

URL: https://github.com/llvm/llvm-project/commit/d4545e6fa0366718c2416d3578dd4e1f26855c29
DIFF: https://github.com/llvm/llvm-project/commit/d4545e6fa0366718c2416d3578dd4e1f26855c29.diff

LOG: Revert "[RISCV] Enable strict assertions in InsertVSETVLI data flow"

This reverts commit 79a66ec97b4fb8cbc4e0a81ead356caf5507a6ea.

The stronger asserts served their purpose; I stumbled across another bug.  Will reapply once this one is also fixed.

The bug appears to be a variant of a previous one:
* We mutate an instruction in one block.
* That mutation changes the phase3 results of another block.

This is very similiar to a previous issue, except cross block instead of within a single block.

Added: 
    

Modified: 
    llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp b/llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
index fb3220eb9ab5..58ab7f456a9f 100644
--- a/llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
+++ b/llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
@@ -38,7 +38,7 @@ static cl::opt<bool> DisableInsertVSETVLPHIOpt(
     cl::desc("Disable looking through phis when inserting vsetvlis."));
 
 static cl::opt<bool> UseStrictAsserts(
-    "riscv-insert-vsetvl-strict-asserts", cl::init(true), cl::Hidden,
+    "riscv-insert-vsetvl-strict-asserts", cl::init(false), cl::Hidden,
     cl::desc("Enable strict assertion checking for the dataflow algorithm"));
 
 namespace {