[PATCH] D90006: Exposes interface to free up caching data structure in DWARFDebugLine and DWARFUnit for memory management

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks OK otherwise



================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp:402
+      LineData, SecondOffset, *Context, nullptr, RecordRecoverable);
+  ASSERT_TRUE(ExpectedLineTable4.operator bool());
+  EXPECT_FALSE(Recoverable);
----------------
Could this be written as:
```
ASSERT_TRUE(ExpectedLineTable4);
```
? (similarly for other bool tests - in general, explicitly calling operator overloads is a bit "weird" and best avoided if possible - if there's an issue with gtest only testing implicit conversion, then maybe it'd be suitable to explicitly cast to bool: `ASSERT_true((bool)ExpectedLineTable4)`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90006/new/

https://reviews.llvm.org/D90006