[PATCH] D123943: MachineModuleInfo: Move AddrLabelSymbols to AsmPrinter

Tue May 17 15:14:15 PDT 2022

arsenm added a comment.

In D123943#3470045 <https://reviews.llvm.org/D123943#3470045>, @qiongsiwu1 wrote:

> In D123943#3465282 <https://reviews.llvm.org/D123943#3465282>, @arsenm wrote:
>
>> In D123943#3465190 <https://reviews.llvm.org/D123943#3465190>, @qiongsiwu1 wrote:
>>
>>> Hi Matt @arsenm !
>>>
>>> May I check with you why commit https://reviews.llvm.org/rG9209a519180b478f7a77d7c4781ea857536d77ed does not have a link to this patch?
>>>
>>> Thanks!!
>>>
>>> FYI @zibi
>>
>> I don't use arc which adds those comments
>
> Ah got it! Thanks so much for getting back to me! I am a new contributor so I am trying to understand the convention from the community. If you don't mind, could you help me understand if I myself should or should not use `arc`? For commits I am working myself, should I link the reviews to them? Could you offer some pointers for me to stare at? I have gone through https://llvm.org/docs/Contributing.html#how-to-submit-a-patch and https://llvm.org/docs/CodeReview.html and it is not clear to me what convention I should follow.
>
> Thanks for your patience!

If you want to? I'm set in my ways and have given up fighting with arc's workflow the few times I've tried to use it

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123943/new/

https://reviews.llvm.org/D123943