[PATCH] D124508: [NFC][AMDGPU][CodeGen] Use ArrayRef in TargetLowering functions

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 14:51:09 PDT 2022


rampitec added a comment.
Herald added subscribers: kosarev, jsilvanus.

Sorry for delay, thanks for doing this!
This is LGTM, except it needs a rebase: ISD::SCALAR_TO_VECTOR for Vec16 has changed since this was created.



================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:614
+                         Custom);
+      setOperationAction({ISD::INSERT_VECTOR_ELT, ISD::SCALAR_TO_VECTOR}, Vec16,
+                         Expand);
----------------
ISD::SCALAR_TO_VECTOR was changed to Custom in the D124734.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124508/new/

https://reviews.llvm.org/D124508



More information about the llvm-commits mailing list