[PATCH] D125810: [LV] Do not LoopSimplify/LCSSA after generating main vector loop.

Bardia Mahjour via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 13:43:24 PDT 2022


bmahjour added a comment.

IIRC the reason for calling `formLCSSARecursively` was to make sure we can handle live outs and reductions properly, which we seem to still be able to do (based on LIT test updates). The call to `simplifyLoop` was to ensure we don't trip any assumptions about loop simplify form when processing the epilogue loop. It may not be an issue now, but would it be a problem, say if a hypothetical utility function common to both paths wants to assert that the loop is in simplified form? Is keeping `simplifyLoop()` harmless to VPlan's modeling of exit values?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125810/new/

https://reviews.llvm.org/D125810



More information about the llvm-commits mailing list