[PATCH] D125833: [ObjCopy][NFC] Remove unneeded zero initialization

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 12:59:44 PDT 2022


MaskRay created this revision.
MaskRay added a reviewer: alexander-shaposhnikov.
Herald added subscribers: StephenFan, abrachet, hiraditya.
Herald added a reviewer: jhenderson.
Herald added a project: All.
MaskRay requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

getNewMemBuffer has called memset.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D125833

Files:
  llvm/lib/ObjCopy/MachO/MachOWriter.cpp


Index: llvm/lib/ObjCopy/MachO/MachOWriter.cpp
===================================================================
--- llvm/lib/ObjCopy/MachO/MachOWriter.cpp
+++ llvm/lib/ObjCopy/MachO/MachOWriter.cpp
@@ -651,7 +651,6 @@
     return createStringError(errc::not_enough_memory,
                              "failed to allocate memory buffer of " +
                                  Twine::utohexstr(TotalSize) + " bytes");
-  memset(Buf->getBufferStart(), 0, totalSize());
   writeHeader();
   writeLoadCommands();
   writeSections();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125833.430172.patch
Type: text/x-patch
Size: 533 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220517/28dc3ad2/attachment.bin>


More information about the llvm-commits mailing list