[PATCH] D125830: [Analysis] Avoid virtual dtor. NFC.

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 12:22:42 PDT 2022


Meinersbur created this revision.
Meinersbur added reviewers: dblaikie, YangKeao.
Herald added a project: All.
Meinersbur requested review of this revision.
Herald added a project: LLVM.

Replace virtual destructor by a protected non-virtual one. Additionally also making derived structs as virtual avoids the warning from reappearing.

Also see the mailing list discussion: https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20220516/1038290.html


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D125830

Files:
  llvm/include/llvm/Analysis/DOTGraphTraitsPass.h
  llvm/include/llvm/Analysis/DomPrinter.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125830.430158.patch
Type: text/x-patch
Size: 4782 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220517/2791b456/attachment.bin>


More information about the llvm-commits mailing list