[llvm] 79a66ec - [RISCV] Enable strict assertions in InsertVSETVLI data flow

[Philip Reames via llvm-commits]

Author: Philip Reames
Date: 2022-05-17T11:12:31-07:00
New Revision: 79a66ec97b4fb8cbc4e0a81ead356caf5507a6ea

URL: https://github.com/llvm/llvm-project/commit/79a66ec97b4fb8cbc4e0a81ead356caf5507a6ea
DIFF: https://github.com/llvm/llvm-project/commit/79a66ec97b4fb8cbc4e0a81ead356caf5507a6ea.diff

LOG: [RISCV] Enable strict assertions in InsertVSETVLI data flow

These asserts are believed to hold after several recent miscompiles have been fixed.  If you see an assertion failure on this change, please toggle the default back and make sure you file a bug with a reproducer.  We may have as yet uncaught miscompiles lurking in this code.

Differential Revision: https://reviews.llvm.org/D125271

Added: 
    

Modified: 
    llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp b/llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
index 2e46a8ba6ad4..0ef70dacce08 100644
--- a/llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
+++ b/llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
@@ -38,7 +38,7 @@ static cl::opt<bool> DisableInsertVSETVLPHIOpt(
     cl::desc("Disable looking through phis when inserting vsetvlis."));
 
 static cl::opt<bool> UseStrictAsserts(
-    "riscv-insert-vsetvl-strict-asserts", cl::init(false), cl::Hidden,
+    "riscv-insert-vsetvl-strict-asserts", cl::init(true), cl::Hidden,
     cl::desc("Enable strict assertion checking for the dataflow algorithm"));
 
 namespace {