[PATCH] D125812: [RISCV] Canonicalize AVL=setvli to AVL=Imm or AVL=VLMAX

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 11:01:18 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:1265
+              VSETVLIInfo DefInfo = getInfoForVSETVLI(*DefMI);
+              if (DefInfo.hasSameVTYPE(Require) &&
+                  (DefInfo.hasAVLImm() || DefInfo.getAVLReg() == RISCV::X0)) {
----------------
craig.topper wrote:
> Can this be hasSameVLMAX instead of hasSameVTYPE?
Oh I guess that's what the TODO in the comment was. Is there any reason to not do that now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125812/new/

https://reviews.llvm.org/D125812



More information about the llvm-commits mailing list