[PATCH] D125741: [NFC][RISCV] Enable FeatureNoDefaultUnroll feature to control targets which use default unroll preference

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 10:55:44 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:355
 
-  // Support explicit targets enabled for SiFive with the unrolling preferences
-  // below
-  bool UseDefaultPreferences = true;
-  if (ST->getProcFamily() == RISCVSubtarget::SiFive7)
-    UseDefaultPreferences = false;
-
-  if (UseDefaultPreferences)
+  // Support explicit targets with the default unrolling preferences.
+  if (ST->enableDefaultUnroll())
----------------
craig.topper wrote:
> "explicit targets" no longer makes sense here since you removed the flag and inverted the comment.
Oops I mean. "explicit targets" no longer makes sense here since you added the flag and inverted the comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125741/new/

https://reviews.llvm.org/D125741



More information about the llvm-commits mailing list