[PATCH] D125335: Give option to use isCopyInstr to determine which MI is treated as Copy instruction in MCP

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 10:04:23 PDT 2022


lkail added a comment.

> The problem (my concern) here is some architecture may not be ready to use isCopyInstr to identify what a COPY is.

IIUC, `isCopyInstrImpl` hasn't been override by many targets and returns `None`, I think it doesn't affect these targets in MCP. Even when `MI.isCopy()` returns false, and then `isCopyInstr` returns true, you still have chance to decide if it's feasible to perform propagation based on this MI's operands' flags and etc. As I have said, you can implement conservative checks in your first patch(sufficient to cover your cases) and enhance it in following patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125335/new/

https://reviews.llvm.org/D125335



More information about the llvm-commits mailing list