[PATCH] D124910: [SCEV] Use umin_seq for BECount of multi-exit loops

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

Please rebase when you get a chance.  Want to see what the revised test diffs look like.

Assuming they're not terrible, I'm planning to LGTM this.  This is a active miscompile, and while we might need to revert if practical perf impacts are too terrible, my default is to fix the bug and only closely examine the perf if we have evidence we need to.



================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:8144
 
-  return SE->getUMinFromMismatchedTypes(Ops);
+  return SE->getUMinFromMismatchedTypes(Ops, /* Sequential */ true);
 }
----------------
This definitely deserves a comment.  :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124910/new/

https://reviews.llvm.org/D124910