[PATCH] D125377: [AArch64] Order STP Q's by ascending address

Andre Vieira via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 03:36:23 PDT 2022


avieira added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetMachine.cpp:484
       // pseudos then (v. addPreSched2()).
-      ScheduleDAGMI *DAG = createGenericSchedPostRA(C);
       DAG->addMutation(createAArch64MacroFusionDAGMutation());
       return DAG;
----------------
fhahn wrote:
> Might make sense to move the code from `AArch64MacroFusion.cpp` to the new `"AArch64MachineScheduler.h"`
I don't have strong feelings about this, but other targets seem to keep mutations and MachineScheduler definitions separately. Could put them all in the same file if you prefer or leave it as is... I do assume you meant merge AArch64MacroFusion.{h,cpp} with respectively AArch64MachineScheduler.{h,cpp}.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125377/new/

https://reviews.llvm.org/D125377



More information about the llvm-commits mailing list