[PATCH] D125699: [StackColoring] Don't merge slots with differing StackIDs

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added inline comments.


================
Comment at: llvm/lib/CodeGen/StackColoring.cpp:1322
+        // Objects with different stack IDs cannot be merged.
+        if (MFI->getStackID(SortedSlots[I]) != MFI->getStackID(SortedSlots[J]))
+          continue;
----------------
sdesmalen wrote:
> minor nit: if you move this code two lines below, you can use `FirstSlot` and `SecondSlot`.
Ach of course, thank you. And I'm glad you got in touch as I woke up this morning feeling guilty I hadn't notified any AArch64 people when this might (and indeed does) affect them :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125699/new/

https://reviews.llvm.org/D125699