[PATCH] D125324: AMDGPU/GISel: Factor out AMDGPURegisterBankInfo::buildReadFirstLane

[Ivan Kosarev via Phabricator via llvm-commits]

kosarev added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:719
+
+    const TargetRegisterClass *Constrained =
+        constrainGenericRegister(SrcPart, AMDGPU::VGPR_32RegClass, MRI);
----------------
arsenm wrote:
> kosarev wrote:
> > Putting this under `#ifndef NDEBUG` would prevent calling `constrainGenericRegister()` in no-asserts builds.
> Why would you want to do that? The operands always need to be constrained
Yep, I misread it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125324/new/

https://reviews.llvm.org/D125324