[PATCH] D125732: [lld-macho] Demangle symbol name in export error msg when -demangle is specified

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 22:15:20 PDT 2022


oontvoo added a comment.

In D125732#3517791 <https://reviews.llvm.org/D125732#3517791>, @thakis wrote:

> Linker behavior, including error output order, should be deterministic. (This allows caching results etc)

I agree.

> So it's not the test that's bad, it's the code.
>
> I'd advise reverting and fixing async.

However the indeterminism isn't introduced by this patched. It's been there already (that is, the code that checks the list of exported symbols runs in parallel)
will look into how to fix the indeterminism there


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125732/new/

https://reviews.llvm.org/D125732



More information about the llvm-commits mailing list