[PATCH] D125732: [lld-macho] Demangle symbol name in export error msg when -demangle is specified

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added a comment.

Seemed to fail on windows bot:

  $ ":" "RUN: at line 12"
  $ "not" "ld64.lld" "-arch" "x86_64" "-platform_version" "macos" "11.0" "11.0" "-syslibroot" "C:/buildbot-root/llvm-clang-x86_64-sie-win/llvm-project/lld/test\MachO\Inputs\MacOSX.sdk" "-fatal_warnings" "-exported_symbol" "__ZTIN3foo3bar4MethE" "-exported_symbol" "__ZTSN3foo3bar4MethE" "C:\buildbot-root\llvm-clang-x86_64-sie-win\build\tools\lld\test\MachO\Output\demangle.s.tmp/export-symbols.o" "-o" "/dev/null"
  $ "c:\buildbot-root\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe" "--check-prefix=EXPORT" "C:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\lld\test\MachO\demangle.s"
  $ ":" "RUN: at line 13"
  $ "not" "ld64.lld" "-arch" "x86_64" "-platform_version" "macos" "11.0" "11.0" "-syslibroot" "C:/buildbot-root/llvm-clang-x86_64-sie-win/llvm-project/lld/test\MachO\Inputs\MacOSX.sdk" "-fatal_warnings" "-demangle" "-exported_symbol" "__ZTIN3foo3bar4MethE" "-exported_symbol" "__ZTSN3foo3bar4MethE" "C:\buildbot-root\llvm-clang-x86_64-sie-win\build\tools\lld\test\MachO\Output\demangle.s.tmp/export-symbols.o" "-o" "/dev/null"
  $ "c:\buildbot-root\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe" "--check-prefix=DEMANGLE-EXPORT" "C:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\lld\test\MachO\demangle.s"
  # command stderr:
  C:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\lld\test\MachO\demangle.s:22:20: error: DEMANGLE-EXPORT: expected string not found in input
  # DEMANGLE-EXPORT: cannot export hidden symbol typeinfo for foo::bar::Meth
                     ^
  <stdin>:4:78: note: scanning from here
  ld64.lld: error: cannot export hidden symbol typeinfo name for foo::bar::Meth
                                                                               ^
  <stdin>:5:101: note: possible intended match here
  >>> defined in C:\buildbot-root\llvm-clang-x86_64-sie-win\build\tools\lld\test\MachO\Output\demangle.s.tmp/export-symbols.o
                                                                                                      ^
  
  Input file: <stdin>
  Check file: C:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\lld\test\MachO\demangle.s
  
  -dump-input=help explains the following input dump.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125732/new/

https://reviews.llvm.org/D125732