[PATCH] D125435: [TableGen][DirectX] Add tableGen backend to generate DXIL operation for DirectX backend.

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DXIL.td:36
+  int dxil_opid = 0;      // ID of DXIL operation
+  string dxil_class = ""; // name of the opcode class
+  string category = "";   // classification for this instruction
----------------
nhaehnle wrote:
> It's hard to tell how you're going to use these variables, but I suspect that a more idiomatic solution would be to have `DxilClass` and `Category` classes here; they can be dummy "marker" classes, like so:
> ```
> class dxil_class;
> class dxil_category;
> 
> def unary : dxil_class;
> def unary_float : dxil_category;
> ```
Does DXIL Class need to be a string field here or can it just be the TableGen record class?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125435/new/

https://reviews.llvm.org/D125435