[PATCH] D125404: [SPIR-V] Add simple tests to improve test coverage

[Andrey Tretyakov via Phabricator via llvm-commits]

andreytr marked 2 inline comments as done.
andreytr added inline comments.


================
Comment at: llvm/test/CodeGen/SPIRV/TruncToBool.ll:9-10
+; ModuleID = 'main'
+target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-n8:16:32:64"
+target triple = "spirv64-unknown-unknown"
+
----------------
arsenm wrote:
> andreytr wrote:
> > arsenm wrote:
> > > Generally tests use -mtriple on the command line and don't repeat the triple/datalayout in the IR
> > Without "target triple = "spirv64-unknown-unknown" " it compiles x86 assembler.
> Yes, but you can move it to the -mtriple argument to llc instead of putting it in the source
Will try it (later).


================
Comment at: llvm/test/CodeGen/SPIRV/optnone.ll:17
+
+attributes #0 = { nounwind optnone noinline "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-frame-pointer-elim"="false" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="false" }
----------------
zuban32 wrote:
> Some (or all) of these attributes look redundant as well
Necessary (for passing) only "noinline" (it explicitly checked), but see comment "Check that optnone is correctly ignored...".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125404/new/

https://reviews.llvm.org/D125404