[PATCH] D125335: Pass lamba to MachineCopyProp to determine which MI is treated as Copy instruction.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

I don't understand the problem this is supposed to solve



================
Comment at: llvm/lib/CodeGen/MachineCopyPropagation.cpp:297
+    // Use isCopyInstr().
+    if (UseCopyInstr || EnableCopyInstr) {
+      PredicateCopy = [](const MachineInstr &MI) {
----------------
I don't understand the meaning of this pass parameter


================
Comment at: llvm/test/CodeGen/AArch64/O3-pipeline.ll:202
 ; CHECK-NEXT:       AArch64 load / store optimization pass
+; CHECK-NEXT:       Machine Copy Propagation Pass
 ; CHECK-NEXT:       Workaround A53 erratum 835769 pass
----------------
Was this not already run? Is this adding a second instance?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125335/new/

https://reviews.llvm.org/D125335