[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

Mon May 16 12:52:10 PDT 2022

erichkeane added a comment.

In D124726#3516896 <https://reviews.llvm.org/D124726#3516896>, @ken-matsui wrote:

> @nathanchance
>
> Oops, thank you for your comment!
> I would like to work on a hotfix patch for this issue.
>
> @aaron.ballman
>
> Should we entirely opt-out of this suggestion on `.S` files? I think there are other approaches here, such as decreasing the max edit distance to avoid suggesting this case in `.S` files, but this approach is avoiding just this edge case so that it would possibly bring a new issue like this. Conversely, opting out of this suggestion on the whole `.S` files will not be able to catch any typoes. Considering possible edge cases (`#` directives are also treated as comments), I think opting out would be the only way, unfortunately. What do you think?
>
> For now, I will create a patch opting out of this suggestion on `.S` files.

I believe the `if (getLangOpts().AsmPreprocessor)` condition is appropriately accurate here.  I don't think changing the edit distance would be a good behavior for anyone, and I don't see any other appropriate heuristics.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124726/new/

https://reviews.llvm.org/D124726