[PATCH] D125648: [ARM SEH 6] [ARM] Add SEH opcodes in frame lowering

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 12:40:24 PDT 2022


efriedma added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMFrameLowering.cpp:1126
+        // contain a stable frame pointer, thus manually insert a .seh_nop
+        // here instead.
+        auto SEH = BuildMI(MF, dl, TII.get(ARM::SEH_Nop))
----------------
We shouldn't be encoding stack realignment into the unwind data.  It's basically a dynamic allocation: we have to emit a frame pointer before we realign the stack, and we should cut off the unwind prologue immediately after the frame pointer is set up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125648/new/

https://reviews.llvm.org/D125648



More information about the llvm-commits mailing list