[PATCH] D125647: [ARM SEH 5] [MC] [Win64EH] Check that the SEH unwind opcodes match the actual instructions

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 12:29:59 PDT 2022


efriedma added inline comments.


================
Comment at: llvm/lib/Target/ARM/MCTargetDesc/ARMWinCOFFStreamer.cpp:256
+#ifndef NDEBUG
+  MCSymbol *Label = S.emitCFILabel();
+  CurFrame->EpilogEnd[CurrentEpilog] = Label;
----------------
I don't like changing whether we emit a label based on NDEBUG; that will affect the actual assembler text.  (The actual checking is also probably cheap enough we could just leave it on, but I'll leave that up to you.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125647/new/

https://reviews.llvm.org/D125647



More information about the llvm-commits mailing list