[PATCH] D125287: [SLP] Improve root steering by building actual trees instead of calling the look-ahead heuristic

[Valeriy Dmitriev via Phabricator via llvm-commits]

vdmitrie added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:849
+  /// instruction bundles that can actually get codegened.
+  bool ForceDisableScheduling = false;
 
----------------
(If we finally agree with taking this path)
It should probably be possible to introduce simulation mode to BlockScheduling rather than guard each BS interface call.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:905
+  /// the purpose of scheduling and extraction in the \p UserIgnoreLst. The tree
+  /// will have at least \p MaxSize nodes if this argument is passed. Setting \p
+  /// DisableSCheduling saves compilation time but generates a tree that is not
----------------
this description update is seems leftover from the previous diff (i.e. not intentional)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125287/new/

https://reviews.llvm.org/D125287