[PATCH] D124936: [VPlan] Move usesScalars/onlyFirstLaneUsed to VPUser.

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 10:51:45 PDT 2022


Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

Looks good! Minor documentation update nits.



================
Comment at: llvm/lib/Transforms/Vectorize/VPlanValue.h:291
+
+  /// Returns true if the recipe uses scalars of operand \p Op. Conservatively
+  /// returns if only first (scalar) lane is used, as default.
----------------
nit: "recipe" >> "VPUser"?


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanValue.h:299
+
+  /// Returns true if the recipe only uses the first lane of operand \p Op.
+  /// Conservatively returns false.
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124936/new/

https://reviews.llvm.org/D124936



More information about the llvm-commits mailing list