[PATCH] D125703: [RISCV] Fix missing vsetvli in transparent block case

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 10:45:18 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:1126
+        CurInfo = BlockInfo[MBB.getNumber()].Pred;
         assert(BlockInfo[MBB.getNumber()].Pred.isValid() &&
                "Expected a valid predecessor state.");
----------------
Use CurInfo in the assert?


================
Comment at: llvm/test/CodeGen/RISCV/rvv/vsetvli-insert-crossbb.ll:30
 ; CHECK-NEXT:    vfadd.vv v8, v8, v9
+; CHECK-NEXT:    vsetvli zero, a0, e64, m1, ta, mu
 ; CHECK-NEXT:    ret
----------------
Does this mean that ExitInfo and CurInfo don't match at the end? Why did that occur? There's nothing that has any special cases in this function.

Is it because of the AVL being from a vsetvli?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125703/new/

https://reviews.llvm.org/D125703



More information about the llvm-commits mailing list