[PATCH] D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis.

Kazu Hirata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 10:43:10 PDT 2022


kazu added a comment.

In D125495#3510338 <https://reviews.llvm.org/D125495#3510338>, @mingmingl wrote:

> In D125495#3510137 <https://reviews.llvm.org/D125495#3510137>, @davidxl wrote:
>
>> It might be worth annotating the early inliner for PGO as well.
>
> To confirm if I'm understanding it correctly, you mean we should annotate the "early"  (i.e., not profile-driven) information for those inline transformations that are are made without PGO profiles [1].
>
> Ask since the early inliner is annotated with prelink/postlink information (same line around line 630 by construction of ModuleInlinerWrapperPass instance)

I am not David, but yes, it would be nice to be able to differentiate the early inlining and rhw profile-driven inlining in the FDO scenario.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125495/new/

https://reviews.llvm.org/D125495



More information about the llvm-commits mailing list