[PATCH] D125404: [SPIR-V] Add simple tests to improve test coverage

Aleksandr Bezzubikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 10:35:39 PDT 2022


zuban32 added inline comments.


================
Comment at: llvm/test/CodeGen/SPIRV/TruncToBool.ll:13
+; Function Attrs: nounwind
+define spir_kernel void @test(i32 %op1, i32 %op2, i8 %op3) !kernel_arg_addr_space !1 !kernel_arg_access_qual !2 !kernel_arg_type !3 !kernel_arg_base_type !4 !kernel_arg_type_qual !5 {
+entry:
----------------
I think we should try get rid of unnecessary metadata as much as possible, I don't think `kernel_arg_*` matters for this test for example, since it only checks for emitting proper opcodes. The same is fair for some of the `opencl.*` MD or any other.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125404/new/

https://reviews.llvm.org/D125404



More information about the llvm-commits mailing list