[PATCH] D125658: [ifs] Switch to using OptTable

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Thanks for the patch. User-facing tools are better using llvm::OptTable. I've only spot one thing other than what has been mentioned.



================
Comment at: llvm/tools/llvm-ifs/Opts.td:33
+defm output : Eq<"output", "Output file **DEPRECATED**">;
+def : Joined<["--"], "o">, HelpText<"Alias for --output">, Alias<output_EQ>;
+defm output_elf : Eq<"output-elf", "Output path for ELF file">;
----------------
`--o` looks a bit weird. The convention for short options is `-o`. You may need to check whether your downstream uses `--o` and removes the usage.

It's fine to support both `-` and `--` for now and remove `--` later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125658/new/

https://reviews.llvm.org/D125658