[PATCH] D125671: [InstCombine] Allow undef vectors when foldSelectToCopysign

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 10:16:50 PDT 2022


spatel added a comment.

In D125671#3516360 <https://reviews.llvm.org/D125671#3516360>, @spatel wrote:

> This does not look correct.
>
> In the example test, if both elements of X are negative, we should return <-42.0, -42.0>. But after this transform, we will return <-42.0, undef>?

Sorry - I missed the invert / fneg. That should be:

In the example test, if both elements of X are **positive**, we should return <-42.0, -42.0>. But after this transform, we will return <-42.0, undef>?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125671/new/

https://reviews.llvm.org/D125671



More information about the llvm-commits mailing list