[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Looks good to me. I generally agree with Adrian's suggestions.



================
Comment at: llvm/test/DebugInfo/COFF/global-no-strings.ll:1
+; RUN: llc < %s | FileCheck %s
+; RUN: llc < %s -filetype=obj | llvm-readobj - --codeview | FileCheck %s
----------------
test lgtm, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123534/new/

https://reviews.llvm.org/D123534