[PATCH] D125514: [WebAssembly] Use CHECK-NEXT for irreducible-cfg.mir
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 16 08:30:05 PDT 2022
asb added a comment.
In D125514#3510886 <https://reviews.llvm.org/D125514#3510886>, @aheejin wrote:
> The script doesn't generate `CHECK` lines next to each BB but rather generates the whole function together, making it harder to see changes in each BB for me. Also there are comments for `CHECK` lines, which will be lost if we use the script. So I'm not sure using it will improve readability in this case.
No problem with leaving it as-is - just thought I'd raise the suggestion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125514/new/
https://reviews.llvm.org/D125514
More information about the llvm-commits
mailing list