[PATCH] D125474: [DWARFLinker][NFC] Add None value to the DwarfLinkerAccelTableKind enum.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: llvm/tools/dsymutil/dsymutil.cpp:209-227
+static Expected<DwarfLinkerAccelTableKind>
+getAccelTableKind(opt::InputArgList &Args) {
   if (opt::Arg *Accelerator = Args.getLastArg(OPT_accelerator)) {
     StringRef S = Accelerator->getValue();
     if (S == "Apple")
-      return AccelTableKind::Apple;
+      return DwarfLinkerAccelTableKind::Apple;
     if (S == "Dwarf")
----------------
avl wrote:
> JDevlieghere wrote:
> > Should we update this and allow `None` as a valid input for dsymutil? 
> we can, if we want None for dsymutil. Will update this patch accordingly.
It seems straightforward enough that we might as well support it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125474/new/

https://reviews.llvm.org/D125474