[PATCH] D125688: [MCParser] Set default alignment value when meeting invalid align

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 08:10:48 PDT 2022


nikic added a comment.

In D125688#3515930 <https://reviews.llvm.org/D125688#3515930>, @serge-sans-paille wrote:

> In D125688#3515834 <https://reviews.llvm.org/D125688#3515834>, @nikic wrote:
>
>> Is it possible to add a test for this?
>
> I wonder... is there a way to make the difference between an error and an abort? Because without this patch we get an error message followed by an abort, and with this patch we only get the error.

I think a test that aborts would always fail by default unless `not --crash` is used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125688/new/

https://reviews.llvm.org/D125688



More information about the llvm-commits mailing list