[PATCH] D125310: [AArch64][RISCV][SelectionDAG] Support VECREDUCE_ADD mask operations

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 08:09:46 PDT 2022


reames added a comment.

Please go ahead and land the new tests, and then rebase so that changes in codegen are visible in review.  Also, please rebase over the mentioned Aarch64 review.  The test diff there currently looks like a regression because you haven't stacked the changes which was confusing at first.

The submission comment needs improved to describe what this is actually doing.

The patch seems generally reasonable.  Once the above are done, should be an easy LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125310/new/

https://reviews.llvm.org/D125310



More information about the llvm-commits mailing list