[PATCH] D125527: [CostModel][X86] getScalarizationOverhead - improve extraction costs for > 128-bit vectors

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 07:47:55 PDT 2022


ABataev added inline comments.


================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.cpp:3898
+
+        Cost += DemandedUpper128Lanes.countPopulation();
+
----------------
Can we estimate regcopy somehow here?


================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.cpp:3905
+            unsigned Idx = I % Scale;
+            Cost += getVectorInstrCost(Instruction::ExtractElement, Ty, Idx);
+          }
----------------
Maybe use BaseT::getScalarizationOverhead again here rather than `getVectorInstrCost(Instruction::ExtractElement`? Also, what about possible getExtractWithExtendCost here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125527/new/

https://reviews.llvm.org/D125527



More information about the llvm-commits mailing list