[llvm] 6ef17f2 - [AMDGPU] Mark sendmsg hasSideEffects. NFC

Joe Nash via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 07:26:55 PDT 2022


Author: Joe Nash
Date: 2022-05-16T09:59:27-04:00
New Revision: 6ef17f20d940dc771c14b83ac1eabdb526575b2a

URL: https://github.com/llvm/llvm-project/commit/6ef17f20d940dc771c14b83ac1eabdb526575b2a
DIFF: https://github.com/llvm/llvm-project/commit/6ef17f20d940dc771c14b83ac1eabdb526575b2a.diff

LOG: [AMDGPU] Mark sendmsg hasSideEffects. NFC

Address the FIXME by marking the sendmsg instructions with
hasSideEffects.

Reviewed By: foad

Differential Revision: https://reviews.llvm.org/D125569

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/SOPInstructions.td

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/SOPInstructions.td b/llvm/lib/Target/AMDGPU/SOPInstructions.td
index be2a4d386e7b..2c6eda052f38 100644
--- a/llvm/lib/Target/AMDGPU/SOPInstructions.td
+++ b/llvm/lib/Target/AMDGPU/SOPInstructions.td
@@ -1284,12 +1284,15 @@ def S_SETPRIO : SOPP_Pseudo <"s_setprio", (ins i16imm:$simm16), "$simm16",
 }
 
 let Uses = [EXEC, M0] in {
-// FIXME: Should this be mayLoad+mayStore?
 def S_SENDMSG : SOPP_Pseudo <"s_sendmsg" , (ins SendMsgImm:$simm16), "$simm16",
-  [(int_amdgcn_s_sendmsg (i32 timm:$simm16), M0)]>;
+  [(int_amdgcn_s_sendmsg (i32 timm:$simm16), M0)]> {
+  let hasSideEffects = 1;
+}
 
 def S_SENDMSGHALT : SOPP_Pseudo <"s_sendmsghalt" , (ins SendMsgImm:$simm16), "$simm16",
-  [(int_amdgcn_s_sendmsghalt (i32 timm:$simm16), M0)]>;
+  [(int_amdgcn_s_sendmsghalt (i32 timm:$simm16), M0)]> {
+  let hasSideEffects = 1;
+}
 
 } // End Uses = [EXEC, M0]
 


        


More information about the llvm-commits mailing list