[PATCH] D125681: [ARM] Rename the isARMAreaXRegister parameter isIOS to SplitFramePushPop. NFC.

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 04:36:26 PDT 2022


mstorsjo created this revision.
mstorsjo added reviewers: t.p.northover, DavidSpickett, efriedma.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: LLVM.

In f8b0a7af52f8c4ec6b4ddcfe3a6fa75098c9507c in 2016, this parameter
was generalized on the caller side (previously passing
STI.isTargetMachO(), now passing STI.splitFramePushPop()). Rename
the parameter on the receiver side to match the generalization.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D125681

Files:
  llvm/lib/Target/ARM/ARMBaseRegisterInfo.h


Index: llvm/lib/Target/ARM/ARMBaseRegisterInfo.h
===================================================================
--- llvm/lib/Target/ARM/ARMBaseRegisterInfo.h
+++ llvm/lib/Target/ARM/ARMBaseRegisterInfo.h
@@ -43,7 +43,7 @@
 
 /// isARMArea1Register - Returns true if the register is a low register (r0-r7)
 /// or a stack/pc register that we should push/pop.
-static inline bool isARMArea1Register(unsigned Reg, bool isIOS) {
+static inline bool isARMArea1Register(unsigned Reg, bool SplitFramePushPop) {
   using namespace ARM;
 
   switch (Reg) {
@@ -53,25 +53,25 @@
       return true;
     case R8:  case R9:  case R10: case R11: case R12:
       // For iOS we want r7 and lr to be next to each other.
-      return !isIOS;
+      return !SplitFramePushPop;
     default:
       return false;
   }
 }
 
-static inline bool isARMArea2Register(unsigned Reg, bool isIOS) {
+static inline bool isARMArea2Register(unsigned Reg, bool SplitFramePushPop) {
   using namespace ARM;
 
   switch (Reg) {
     case R8: case R9: case R10: case R11: case R12:
       // iOS has this second area.
-      return isIOS;
+      return SplitFramePushPop;
     default:
       return false;
   }
 }
 
-static inline bool isARMArea3Register(unsigned Reg, bool isIOS) {
+static inline bool isARMArea3Register(unsigned Reg, bool SplitFramePushPop) {
   using namespace ARM;
 
   switch (Reg) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125681.429683.patch
Type: text/x-patch
Size: 1379 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220516/dc74b10b/attachment.bin>


More information about the llvm-commits mailing list