[PATCH] D125485: [ArgPromotion] Unify byval promotion with non-byval

[Pavel Samolysov via Phabricator via llvm-commits]

psamolysov added a comment.

@nikic If you have time, could you make it clear why the `OffsetAndArgPart` alias is defined as `std::pair<int64_t, ArgPart>`, so why `int64_t` is used for Offset, not `uint64_t`? All the LLVM's API for work with offsets, `APInt` (is created from an `uint64_t` value), `StructLayout::getElementOffset` (returns `uint64_t`), etc. Do we really use negative offsets and if not, can the offset part of the pair be replaced with `uint64_t`? Thank you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125485/new/

https://reviews.llvm.org/D125485