[PATCH] D123661: [XCORE][CodeGen][NFC] Use ArrayRef in TargetLowering functions

Nigel Perks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 02:27:55 PDT 2022


nigelp-xmos added a comment.

I am inclined to revert this change, in line with readability and the other targets. I commented above that I found the original structure clearer. Others said similarly in the changes for other targets. I was happy to bring XCore in line with other targets, but they have not gone for multiple operations on one line. So I would prefer to revert, but welcome comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123661/new/

https://reviews.llvm.org/D123661



More information about the llvm-commits mailing list