[PATCH] D107886: [PowerPC] Support huge frame size for PPC64

Mon May 16 01:42:48 PDT 2022

shchenz added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:3244
+  bool isPPC64 = Subtarget.isPPC64();
+  // FIXME: Materialization here is not optimal.
+  if (isInt<16>(Imm)) {
----------------
Can you add the expected pattern to the FIXME for the `not optimal` pattern?

================
Comment at: llvm/test/CodeGen/PowerPC/huge-frame-call.ll:23
+; CHECK-LE-NEXT:    stdux 1, 1, 0
+; CHECK-LE-NEXT:    .cfi_def_cfa_offset -2147483232
+; CHECK-LE-NEXT:    .cfi_offset lr, 16
----------------
Maybe we can avoid these cfi related instructions by adding `nounwind` to the function. Call frame is not a test point for this patch, right?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107886/new/

https://reviews.llvm.org/D107886