[PATCH] D125604: [FileCheck] Catch missspelled directives.

Ivan Kosarev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 01:21:43 PDT 2022


kosarev added a comment.

In D125604#3514983 <https://reviews.llvm.org/D125604#3514983>, @jhenderson wrote:

> Are the TODO cases where the test fails if changing them?

Yes, this and where the fix is not perfectly obvious.



================
Comment at: llvm/test/FileCheck/missspelled-directive.txt:18
+
+P4_COUNT-2: foo
+CHECK4: error: misspelled directive 'P4_COUNT-2:'
----------------
jhenderson wrote:
> What about `P4-COUNT_2`? Is that case not really related?
Yeah, that's intentionally left for later. At the moment I don't even know how severe the problem with `COUNT_*` is, need to try and see.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125604/new/

https://reviews.llvm.org/D125604



More information about the llvm-commits mailing list