[PATCH] D125446: [LegalizeVectorTypes][VP] Add widen and split support for VP_SETCC

Mon May 16 00:31:55 PDT 2022

Jimerlife marked an inline comment as done.
Jimerlife added inline comments.

================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:5230
   // In this case, we also need to split the result of this node as well.
   if (getTypeAction(InVT) == TargetLowering::TypeSplitVector) {
     SDValue SplitVSetCC = SplitVecOp_VSETCC(N);
----------------
frasercrmck wrote:
> What if we hit this case? It looks like it might silently just work and generate non-VP code. It's not the end of the world but might be unexpected. Can we test this particular path with RISC-V? I'm not sure we can..
> 
> My first thought is that maybe we should add support for splitting VP_SETCC first so we know this function works in principle, then come back to widening afterwards.
I add SplitVecOp_VSETCC and SplitVecRes_SETCC for vp.setcc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125446/new/

https://reviews.llvm.org/D125446