[PATCH] D124980: [Mips] Implement hasDivRemOp()

[Simon Dardis via Phabricator via llvm-commits]

sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

Nit: the summary should have the line--"This resolves PR/54991" to aid in bug tracking.

LGTM.

For the background on MIPS lacking TTI information, other support was more important at the time, though it was on my todo list.

Let me know if you need someone to commit this on your behalf.

Thanks for the report & patch!



================
Comment at: llvm/lib/Target/Mips/CMakeLists.txt:66
   MipsMulMulBugPass.cpp
+  MipsTargetTransformInfo.cpp
 
----------------
Nit: This line should be after the MipsTargetObjectFile.cpp to attempt to keep the alphabetical ordering of the entries in this stanza.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124980/new/

https://reviews.llvm.org/D124980