[PATCH] D125600: [SelectionDAGBuilder] Pass fast math flags to most of VP SDNodes.

[Yeting Kuo via Phabricator via llvm-commits]

fakepaper56 marked an inline comment as done.
fakepaper56 added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7604
     if (I == EVLParamPos)
       Op = DAG.getNode(ISD::ZERO_EXTEND, DL, EVLParamVT, Op);
     OpValues.push_back(Op);
----------------
craig.topper wrote:
> If we hit this line on an FP operation with fast math flags, would we add fast math flags to an ISD::ZERO_EXTEND?
> 
> Might be safer to pass the flags to the DAG.getNode call in the default case.
Thank your reminder. I fix the bug in the latest update.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125600/new/

https://reviews.llvm.org/D125600