[PATCH] D125609: [ADT] Adopt the new casting infrastructure for PointerUnion

Aman LaChapelle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 14 22:23:06 PDT 2022


bzcheeseman added a comment.

Also looking at the build failure - you may need to provide `To *` as the template argument `NullableValueCastFailed`? I'm not 100% sure but based on 5 seconds of looking at the usage.

It looks like when people use PointerUnion, they might do `float *f = pu.dyn_cast<float>()` rather than `float *f = pu.dyn_cast<float *>()`, in which case some of these tests may need some editing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125609/new/

https://reviews.llvm.org/D125609



More information about the llvm-commits mailing list