[PATCH] D125609: [ADT] Adopt the new casting infrastructure for PointerUnion

[Sheng via Phabricator via llvm-commits]

0x59616e added inline comments.


================
Comment at: llvm/include/llvm/ADT/PointerUnion.h:243
+struct CastInfo<To, const PointerUnion<PTs...>>
+    : ConstStrippingForwardingCast<To, const PointerUnion<PTs...>,
+                                   CastInfo<To, PointerUnion<PTs...>>> {};
----------------
bzcheeseman wrote:
> Public inheritance here too. Do you have checks that `const` is handled correctly?
I've added some test for const case, but I'm not sure whether it's comprehensive enough or not.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125609/new/

https://reviews.llvm.org/D125609