[PATCH] D125609: [ADT] Adopt the new casting infrastructure for PointerUnion

[Sheng via Phabricator via llvm-commits]

0x59616e updated this revision to Diff 429503.
0x59616e marked 4 inline comments as done.
0x59616e added a comment.

Given that I'm still young to C++ and llvm, every suggestion, even the
one you feel it's trivial, are very welcomed ;)

This diff comes with the following updates:

- Define PointerUnion::is and ::get in terms of isa<T> and cast<T>.
- Add `FIXME` comment for is(), get() and dyn_cast().


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125609/new/

https://reviews.llvm.org/D125609

Files:
  llvm/include/llvm/ADT/PointerUnion.h
  llvm/unittests/ADT/PointerUnionTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125609.429503.patch
Type: text/x-patch
Size: 8039 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220515/5b10f9cb/attachment.bin>