[PATCH] D125544: [lld][ELF] Support linking 'elf32-avr' with linker scripts

[Ben Shi via Phabricator via llvm-commits]

benshi001 marked 2 inline comments as done.
benshi001 added inline comments.


================
Comment at: lld/test/ELF/linkerscript/avr5-sections.test:1
+# REQUIRES: avr
+
----------------
MaskRay wrote:
> benshi001 wrote:
> > MaskRay wrote:
> > > The tests should be merged into one.
> > > 
> > > Add a file-level comment explaining the purpose.
> > > 
> > > Use split-file to avoid `Inputs/*` files.
> > I am not familiar with that.
> > 
> > do you mean:
> > 1. make a unique .s file with assembly
> > 2. echo to a temp linker script
> > 3. do all checks ? 
> `rg split-file` in this directory and see I use split-file.
A file level comment is added.


================
Comment at: lld/test/ELF/linkerscript/avr5-sections.test:1
+# REQUIRES: avr
+
----------------
benshi001 wrote:
> MaskRay wrote:
> > benshi001 wrote:
> > > MaskRay wrote:
> > > > The tests should be merged into one.
> > > > 
> > > > Add a file-level comment explaining the purpose.
> > > > 
> > > > Use split-file to avoid `Inputs/*` files.
> > > I am not familiar with that.
> > > 
> > > do you mean:
> > > 1. make a unique .s file with assembly
> > > 2. echo to a temp linker script
> > > 3. do all checks ? 
> > `rg split-file` in this directory and see I use split-file.
> A file level comment is added.
I have combined all files into `avr5.test` with `split-file`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125544/new/

https://reviews.llvm.org/D125544